feat: create "identity" field for Site #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preserve backwards compatibility
johnnzhou
reviewed
Oct 28, 2025
Collaborator
|
We should also update the api for |
Collaborator
Author
How come? |
johnnzhou
reviewed
Oct 31, 2025
| description: Optional color identifier for the site in hex code | ||
| example: "#FF5733" | ||
| boundary: | ||
| boundary_array: |
Collaborator
Oh, sorry I think i must misread your change |
johnnzhou
reviewed
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of the API used names to identify Sites, which isn't a particularly stable form of identification. So I added an additional field called "identity" and modified the endpoints to use that as the primary identifier of Sites instead of the "name" parameter. The user passes in all fields except for the identity, which is a UUID generated randomly by the backend.